Skip to content

Enforce the cross-kit check in phasing and rebuilding - #7

Merged
mgilardi merged 1 commit into
mainfrom
enforce-s7
Nov 15, 2026
Merged

mgilardi merged 1 commit into
mainfrom
enforce-s7

Conversation

@mgilardi

Copy link
Copy Markdown
Contributor

Closes K655. phaseWithParent and rebuildFromDescendants now call requireRawRelationship before any work: parent-child cM for the tested parent, full-sibling cM between children. The Kits screen lists what each measured pair fits (fittingRelationships, RELATIONSHIP_WORDS).

Tested: 270 tests, typecheck, leak check. New cases: stranger and grandparent as parent, wrong other parent, half siblings. Not seen in the built app.

🤖 Generated with Claude Code

S7 was built but nothing called it. Phasing with a parent and rebuilding
from children both rest on stated relationships, so they now measure the
raw kits first and stop with SanityStop unless the DNA fits: parent-child
for the parent, full siblings for the children. The Kits screen lists the
relationships each measured pair fits.

Tested on simulated kits: a stranger or grandparent as parent, a wrong
other parent and half siblings all stop. The Kits screen text hasn't been
seen in the built app.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@mgilardi
mgilardi merged commit 1af9b23 into main Nov 15, 2026
2 checks passed
@mgilardi
mgilardi deleted the enforce-s7 branch November 15, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant